[patch, fortran] Correct fndecls for some library functions

Tobias Burnus tobias@codesourcery.com
Fri Nov 27 15:46:58 GMT 2020


Hi Thomas,

On 25.11.20 12:58, Tobias Burnus wrote:
> On 15.11.20 18:52, Thomas Koenig via Fortran wrote:
>> +#define ADD_CHAR(c) do { *fp++ = c; *fp++ = ' '; } while(0)
>> ...
>> +  ADD_CHAR ('.');  /* Function return.  */
> Shouldn't this be ".c" instead of ". " as neither global memory is
> read nor written to?
>> +  if (expr->rank == 0)
>> ...
>> +  else
>> +    ADD_CHAR ('w');  /* Return value is a descriptor.  */
> shouldn't this be "o"?
Scratch that - as it is an array descriptor, "w" is correct – the bounds
etc. are not reset.
> Otherwise, it looks good to me.

Tobias

-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter


More information about the Gcc-patches mailing list