[Patch 0/X] HWASAN v4

Matthew Malcomson matthew.malcomson@arm.com
Fri Nov 20 18:42:12 GMT 2020


On 13/11/2020 17:22, Martin Liška wrote:
> On 11/13/20 5:57 PM, Matthew Malcomson wrote:
>> Hi there,
>>
>> Thanks for the heads-up.
>> As it turns out the most recent `libhwasan` crashes when displaying an 
>> address on the stack in Linux.
> 
> Hello.
> 
> What a bad luck.
> 
>>
>> I'm currently working on getting it fixed here 
>> https://reviews.llvm.org/D91344#2393371 
>> <https://reviews.llvm.org/D91344#2393371> .
>> If this hwasan patch series gets approved and if that patch goes in 
>> would it be feasible to bump the libsanitizer merge to whatever 
>> version that would be?
>>
>> If not (maybe because stage1 would be finished?) then could/would we 
>> end up using the LOCAL_PATCHES approach?
> 
> Since now, I would prefer doing cherry picks. Hopefully, we'll end just 
> with couple of patches.

That makes sense, there's just one patch I need 83ac1820.

As far as I can tell from the history, the process is simply to apply 
the patch in GCC, commit it with a ChangeLog etc as if it were a GCC 
patch, and then add the hash into LOCAL_PATCHES as a separate commit.

Is that right?


Given that it looks like the hwasan patch series is nearing going in 
now, I'd like to make sure I know how the library is getting added.

Is the plan something like the below?
1) You add the libhwasan update (i.e. this patch you posted).
2) I add the cherry-pick from LLVM compiler-rt (once it's approved)
     and a separate commit updating LOCAL_PATCHES.
3) I add the hwasan patch series.

Or would it make more sense for me to apply your patch below with 
`--author` using your details (so it goes in the ChangeLog that way)?

Thanks!
Matthew


> 
> Thanks,
> Martin
> 
>>
>> Thanks,
>> Matthew
>> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ 
>>
>> *From:* Martin Liška <mliska@suse.cz>
>> *Sent:* 13 November 2020 16:33
>> *To:* Matthew Malcomson <Matthew.Malcomson@arm.com>; 
>> gcc-patches@gcc.gnu.org <gcc-patches@gcc.gnu.org>
>> *Cc:* jakub@redhat.com <jakub@redhat.com>; Richard Earnshaw 
>> <Richard.Earnshaw@arm.com>; kcc@google.com <kcc@google.com>; 
>> dodji@redhat.com <dodji@redhat.com>; joseph@codesourcery.com 
>> <joseph@codesourcery.com>
>> *Subject:* Re: [Patch 0/X] HWASAN v4
>> On 10/16/20 11:03 AM, Martin Li�ka wrote:
>>> Hello.
>>>
>>> I've just merged libsanitizer and there's the corresponding part that 
>>> includes
>>> libhwasan.
>>>
>>> Martin
>>
>> Hey.
>>
>> I've just made last merge from upstream, there's corresponding hwasan 
>> part.
>>
>> Martin
> 



More information about the Gcc-patches mailing list