[PATCH] [libiberty] Fix write buffer overflow in cplus_demangle

[Jeff Law]

On 11/14/20 6:08 AM, Tim Rühsen wrote:
> Hey,
>
> On 13.11.20 05:45, Jeff Law wrote:
>>
>> On 11/29/19 12:15 PM, Tim Rühsen wrote:
>>> * cplus-dem.c (ada_demangle): Correctly calculate the demangled
>>>    size by using two passes.
>>
>> So I'm not sure why, but I can't get this patch to apply.  What's even
>> more interesting is ada_demangle doesn't seem to have changed since 2010
>> and even if I checkout a Nov 2019 trunk, I still can't apply the patch.
>>
>>
>> I can see what you're doing with your patch (it's primarily introducing
>> a loop where you count on the first pass and allocate on the second and
>> re-indent all the necessary code), I'd prefer not to muck it up trying
>> to apply by hand.
>>
>>
>> Any change you could update the patch so that it applies to the trunk.
>> THe review is done, so it should be able to go straight in.  If you have
>> commit privs (I don't recall if you do or not), you can go ahead and
>> commit it yourself.
>
> hm sorry, I am a bit out of the loop currently. It would be awesome if
> someone with more project knowledge could apply the patch.
>
> From what I can see here, the patch was made on top of binutils-gdb
> commit 3d18c3354209bd42361cb26ec611455cdf8b401b. Hope this helps.
Normally a GIT id would be sufficient...  *But*:
[law@localhost binutils-gdb]$ git checkout
3d18c3354209bd42361cb26ec611455cdf8b401b
fatal: reference is not a tree: 3d18c3354209bd42361cb26ec611455cdf8b401b

Maybe you could send me your cplus-dem.c with and without your patch
installed.  I can probably sort it out from there.



>
>> Sorry for the insane delays here.
>
> That is how life goes ;-)
> A delay is better than never.
Yea, but it shouldn't take this long to get to relatively simple
patches.  It's just been a terrible year.

jeff