[r11-5094 Regression] FAIL: gcc.dg/torture/pr8081.c -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects (test for excess errors) on Linux/x86_64

Jeff Law law@redhat.com
Tue Nov 17 21:34:40 GMT 2020



On 11/17/20 2:13 PM, Jan Hubicka wrote:
> Hi,
> I am testing the following fix.  I manually applied a rejected hunk and
> for some reaosn managed to reverse the conditonal :(
>
> Honza
>
> 	* ipa-icf.c (sem_function::hash_stmt): Fix conditional on
> 	variably_modified_type_p.
> diff --git a/gcc/ipa-icf.c b/gcc/ipa-icf.c
> index 27eeda3a319..6ae842766e6 100644
> --- a/gcc/ipa-icf.c
> +++ b/gcc/ipa-icf.c
> @@ -1459,10 +1459,10 @@ sem_function::hash_stmt (gimple *stmt, inchash::hash &hstate)
>  
>  		ao_ref_init (&ref, gimple_op (stmt, i));
>  		tree t = ao_ref_alias_ptr_type (&ref);
> -		if (variably_modified_type_p (t, NULL_TREE))
> +		if (!variably_modified_type_p (t, NULL_TREE))
>  		  memory_access_types.safe_push (t);
>  		t = ao_ref_base_alias_ptr_type (&ref);
> -		if (variably_modified_type_p (t, NULL_TREE))
> +		if (!variably_modified_type_p (t, NULL_TREE))
>  		  memory_access_types.safe_push (t);
>  	      }
>  	  }
>
Given Sunil's list of failures, this could well be the same issue as the
one I just sent you.  OH wait, it was rejected.  Probably the binary
attachments looked like a virus/spam or somesuch.


jeff



More information about the Gcc-patches mailing list