[PATCH] modref: add missing Param Optimization keywords

Martin Liška mliska@suse.cz
Mon Nov 16 19:44:03 GMT 2020


On 11/16/20 1:25 PM, Jan Hubicka wrote:
>> Hello.
>>
>> This fixes:
>>
>> FAIL: compiler driver --help=common option(s): "^ +-.*[^:.]$" absent from output: "  --param=modref-max-depth=   Maximum depth of DFS walk used by modref escape analysis"
>>
>> Ready to be installed after tests?
>> Thanks,
>> Martin
>>
>> gcc/ChangeLog:
>>
>> 	* params.opt: All modref parameters miss Optimization and Param
>> 	keyword as seen in testsuite failure.
> 
> OK, sorry for that!
> Honza
> 

Hello.

I see the very same error, please grep testsuite logs properly:

FAIL: compiler driver --help=param option(s): "^ +-.*[^:.]$" absent from output: "  --param=modref-max-escape-points= Maximum number of escape points tracked by modref per SSA-name"


commit 1301ca13aa41138597b272bdeade1cdb9438b005
Author: Martin Liska <mliska@suse.cz>
Date:   Mon Nov 16 20:43:31 2020 +0100

     param: Add missing dot for param description.
     
     gcc/ChangeLog:
     
             * params.opt: Add missing dot.

diff --git a/gcc/params.opt b/gcc/params.opt
index 098e0aae7f9..202d92fd601 100644
--- a/gcc/params.opt
+++ b/gcc/params.opt
@@ -933,7 +933,7 @@ Maximum depth of DFS walk used by modref escape analysis.
  
  -param=modref-max-escape-points=
  Common Joined UInteger Var(param_modref_max_escape_points) Init(256) Param Optimization
-Maximum number of escape points tracked by modref per SSA-name
+Maximum number of escape points tracked by modref per SSA-name.
  
  -param=tm-max-aggregate-size=
  Common Joined UInteger Var(param_tm_max_aggregate_size) Init(9) Param Optimization

I'm going to install it.
Martin


More information about the Gcc-patches mailing list