PowerPC: Use __float128 instead of __ieee128 in tests.

Segher Boessenkool segher@kernel.crashing.org
Thu Nov 12 23:38:18 GMT 2020


On Thu, Nov 12, 2020 at 04:44:09PM -0500, Michael Meissner wrote:
> On Thu, Nov 12, 2020 at 01:26:32PM -0600, Segher Boessenkool wrote:
> > On Thu, Oct 22, 2020 at 06:12:31PM -0400, Michael Meissner wrote:
> > > Two of the tests used the __ieee128 keyword instead of __float128.  This
> > > patch changes those cases to use the official keyword.
> > 
> > What is "official" about that?
> > 
> > Why make this change at all?  __ieee128 should work as well!  Did you
> > see failures without this patch?  Thos need fixing, then.
> 
> We document '__float128'.  We don't document '__ieee128'.  As I said, using
> '__ieee128' internally was due some issues in the GCC 7 time frame,
> particularly before we had the glibc changes.

Well, it is a much clearer type as well: __ibm128 is also 128 bits, and
is also a floating point type.  But if __float128 now *always* means
__ieee128, then fine :-)

(But the manual needs fixing in four places, then.)

Is __float128 a standard type?  ("Standard", in whatever context -- not
just a rs6000 GCC thing, and what else uses it then, and/or will other
things use it in the future?)

Also, we then should change things so __ieee128 becomes really only a
legacy alias for __float128.

Thanks,


Segher


More information about the Gcc-patches mailing list