[PATCH] x86: Adjust keylocker testcases for fail on darwin

Uros Bizjak ubizjak@gmail.com
Mon Nov 9 11:50:14 GMT 2020


On Mon, Nov 9, 2020 at 12:47 PM Iain Sandoe <idsandoe@googlemail.com> wrote:
>
> Uros Bizjak via Gcc-patches <gcc-patches@gcc.gnu.org> wrote:
>
> > On Mon, Nov 9, 2020 at 11:50 AM Hongyu Wang <wwwhhhyyy333@gmail.com> wrote:
> >> Hi
> >>
> >> According to the discussion in
> >> https://gcc.gnu.org/pipermail/gcc/2020-November/234096.html,
> >> The testcase for keylocker-* is too strict for darwin target. This
> >> patch adjusted the regex, and add a missing test for aesenc256kl
> >> instruction.
> >>
> >> Tested by Iain Sandone and all get pass in darwin target.
> >>
> >> Ok for trunk?
> >>
> >> gcc/testsuite/ChangeLog
> >>
> >>    * gcc.target/i386/keylocker-aesdec128kl.c: Adjust regex patterns.
> >>    * gcc.target/i386/keylocker-aesdec256kl.c: Likewise.
> >>    * gcc.target/i386/keylocker-aesdecwide128kl.c: Likewise.
> >>    * gcc.target/i386/keylocker-aesdecwide256kl.c: Likewise.
> >>    * gcc.target/i386/keylocker-aesenc128kl.c: Likewise.
> >>    * gcc.target/i386/keylocker-aesencwide128kl.c: Likewise.
> >>    * gcc.target/i386/keylocker-aesencwide256kl.c: Likewise.
> >>    * gcc.target/i386/keylocker-encodekey128.c: Likewise.
> >>    * gcc.target/i386/keylocker-encodekey256.c: Likewise.
> >>    * gcc.target/i386/keylocker-aesenc256kl.c: New test.
> >
> > Please rewrite scan strings back to using double-quotation marks.
>
> out of curiosity, why?

Because this is the convention, and (mostly) all testacases adhere to
this convention.

There should be a compelling reason why this convention should be changed.

> ([IMO] the {} form is generally much more readable, and less prone to
>   uncaught omissions of \ as happened here)

Uros.


More information about the Gcc-patches mailing list