Fwd: libstdc++: Attempt to resolve PR83562

Jonathan Yong 10walls@gmail.com
Sat Nov 7 02:51:39 GMT 2020


On 11/6/20 8:34 AM, Martin Storsjö wrote:
> On Fri, 6 Nov 2020, Liu Hao via Gcc-patches wrote:
> 
>> 在 2020/10/29 下午3:56, Liu Hao 写道:
>>> I forward it here for comments.
>>>
>>> Basing on the behavior of both GCC and Clang, `__cxa_thread_atexit` 
>>> is used to register the
>>> destructor of thread_local objects directly, suggesting the first 
>>> parameter should have `__thiscall`
>>> convention.
>>>
>>> libstdc++ used the default `__cdecl` convention and caused crashes on 
>>> 1686-w64-mingw32 (see
>>> PR83562). But to my surprise, libcxxabi uses `__cdecl` too [1], but I 
>>> haven't heard any of relevant
>>> reports so far.
>>>
>>> Original patch is attached in case you can't find it in gcc-patches.
>>>
> 
> FWIW, this patch looks good and correct to me, from a mingw perspective.
> 
> // Martin


Thanks pushed to gcc master branch as 
7fc0f78c3f43af1967cb7b1ee8f4947f3b890aa2.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0x713B5FE29C145D45_and_old_rev.asc
Type: application/pgp-keys
Size: 7929 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/gcc-patches/attachments/20201107/343d8c7f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://gcc.gnu.org/pipermail/gcc-patches/attachments/20201107/343d8c7f/attachment.sig>


More information about the Gcc-patches mailing list