[patch] Add dg-require-effective-target fpic to an aarch64 specific test in gcc.dg

Richard Sandiford richard.sandiford@arm.com
Fri Nov 6 18:03:41 GMT 2020


Olivier Hainque <hainque@adacore.com> writes:
>> On 4 Nov 2020, at 20:16, Richard Sandiford <richard.sandiford@arm.com> wrote:
>> 
>> Olivier Hainque <hainque@adacore.com> writes:
>>> Hello,
>>> 
>>> This patch adds dg-require-effective-target fpic
>>> to an aarch64 specific gcc.dg test using -fPIC,
>>> which helps circumvent a failure we observed while
>>> testing the aarch64 port for VxWorks.
>>> 
>>> ok to commit ?
>> 
>> OK, thanks.  Also OK for any other current or future aarch64 test that
>> has -fpic or -fPIC in the options and forgets to do this.
>
> Great, thanks Richard!
>
> This echoes what you had actually already told me some
> months ago at
>
>   https://gcc.gnu.org/pipermail/gcc-patches/2019-December/536909.html
>
> which I didn't remember before sending this patch.
>
> For the avoidance of doubt, that would hold for arm
> tests as well, right ?

Yeah, it does.

Thanks,
Richard

> (I'll be careful not to introduce obvious redundancy with e.g.
> os=linux, as pointed out by Jakub earlier this week for another
> set on i386).
>
> Cheers,
>
> Olivier


More information about the Gcc-patches mailing list