[PATCH] i386: Cleanup i386/i386elf.h and align it's return convention with the SVR4 ABI

Pat Bernardi bernardi@adacore.com
Wed Nov 4 23:05:32 GMT 2020


> So, since the unpatched compiler crashes with an example that would
> make a difference, I think the patch is OK as it is.

Thanks for taking the time to look at that Uros, and apologies for not getting back to you sooner.

With regards to your other question:

> So, is it necessary to define DEFAULT_PCC_STRUCT_RETURN ?

It’s not necessary, but a number of other i386 targets like GNU and NetBSD have it explicitly defined. I wasn’t sure if it was for legacy reasons or to document clearly the choice. I can prepare a patch to remove DEFAULT_PCC_STRUCT_RETURN from i386elf.h if you think it would be clearer not to explicitly define it.

Thanks,

Pat Bernardi


More information about the Gcc-patches mailing list