[Patch + RFC][contrib] gcc-changelog/git_commit.py: Check for missing description
Martin Liška
mliska@suse.cz
Tue Nov 3 16:28:49 GMT 2020
On 10/30/20 2:16 PM, Tobias Burnus wrote:
> In terms of issues, it seems as if Ubuntu 20.04.1 LTS has a too
> old unidiff – I copied the check from test_email.py and applied
> it to git_email.py – otherwise, nearly all tests fail.
Hello.
Please apply this hunk separately, it's fine.
>
> Still, I do see some fails – I have attached the fails I got.
> (fails.log, second attachment)
>
> Independent of that, I have now written a check for an empty
> description.
Thanks for it.
I really think the check should support situations where a description
is provided on the next line (first after '\t', so not '\t*') as
you see in the failing test:
libiberty/ChangeLog:
PR lto/97290
* simple-object-elf.c (simple_object_elf_copy_lto_debug_sections):
Use sh_link of a .symtab_shndx section.
Martin
>
> OK for the patch and thoughts about the fails?
>
> Tobias
>
> -----------------
> Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
> Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter
More information about the Gcc-patches
mailing list