[Patch][OpenMP] Fix mapping of artificial variables (PR94874)

Jakub Jelinek jakub@redhat.com
Tue May 26 15:43:16 GMT 2020


On Tue, May 26, 2020 at 04:06:04PM +0200, Jakub Jelinek wrote:
> On Mon, May 25, 2020 at 07:10:31PM +0200, Tobias Burnus wrote:
> > +enum omp_clause_defaultmap_kind
> > +cxx_omp_predetermined_mapping (tree decl)
> > +{
> > +  enum omp_clause_default_kind ret = cxx_omp_predetermined_sharing_1 (decl);
> > +  if (ret != OMP_CLAUSE_DEFAULT_UNSPECIFIED)
> > +    return OMP_CLAUSE_DEFAULTMAP_TO;
> 
> I don't like the above 3 lines, do you need it for anything?
> Static data members certainly aren't covered and it is unlikely we want to
> predetermine them mapped.

And forgot, for this the behavior is already specified in 5.0 that any
reference to this should result in map(tofrom:this[:1]).
It is not implemented yet, but we'll need to implement it some other way
than through this hook.

	Jakub



More information about the Gcc-patches mailing list