[PATCH v1 1/2][PPC64] [PR88877]

kamlesh kumar kamleshbhalui@gmail.com
Mon May 25 07:16:02 GMT 2020


> OTOH, you don't need to name Tuple at all...  It should not *have* a
> constructor, since you declared it as class...  But you can just use
> std::tuple here?

I thought of using std::tuple  but it requires c++11 support.
I am not sure we always build gcc with c++11?

>
> >         (emit_library_call): Added default arg unsigned_p.
> >         (emit_library_call_value): Added default arg unsigned_p.
>
> Yeah, eww.  Default arguments have all the problems you had before,
> except now it is hidden and much more surprising.
>
> Those functions really should take rtx_mode_t arguments?

I was thinking the same. will incorporate this.

./kamlesh


More information about the Gcc-patches mailing list