[PATCH PR94026] combine missed opportunity to simplify comparisons with zero

Segher Boessenkool segher@kernel.crashing.org
Sat May 23 14:57:27 GMT 2020


Hi!

Sorry this is taking so long.

On Wed, May 06, 2020 at 08:57:52AM +0000, Yangfei (Felix) wrote:
> > On Tue, Mar 24, 2020 at 06:30:12AM +0000, Yangfei (Felix) wrote:
> > > I modified combine emitting a simple AND operation instead of making one
> > zero_extract for this scenario.
> > > Attached please find the new patch.  Hope this solves both of our concerns.
> > 
> > This looks promising.  I'll try it out, see what it does on other targets.  (It will
> > have to wait for GCC 11 stage 1, of course).

It creates better code on all targets :-)  A quite small improvement, but
not entirely trivial.

> > p.s.  Please use a correct mime type?  application/octet-stream isn't
> > something I can reply to.  Just text/plain is fine :-)
> 
> I have using plain text now, hope that works for you.  :-)

Nope:

[-- Attachment #2: pr94026-v2.diff --]
[-- Type: application/octet-stream, Encoding: base64, Size: 5.9K --]


Segher


More information about the Gcc-patches mailing list