[committed] Add missing T register clobber for SH port

Jeff Law law@redhat.com
Thu Mar 26 21:59:45 GMT 2020


On Thu, 2020-03-26 at 12:38 -0600, Jeff Law wrote:
> On Wed, 2020-03-25 at 23:10 -0400, Hans-Peter Nilsson wrote:
> > On Wed, 25 Mar 2020, Jeff Law via Gcc-patches wrote:
> > 
> > The patch you sent, as well as what you committed as r10-7383,
> > was just a ChangeLog entry.
> > 
> > > Bootstrapped on sh4-linux-gnu and sh4eb-linux-gnu.  Regression testing in
> > > progress (won't finish for ~12 hours).  No new test as it's covered by
> > > vector-
> > > compare-1 in the testsuite.
> > 
> > ...so I guess you've noticed by the time you read this. :]
> :-)
> 
> Here's the actual patch:
> 
> commit 48817fbd7616f086ac7bb1dd38b862f78762c9b8
> Author: Jeff Law <law@redhat.com>
> Date:   Wed Mar 25 14:33:08 2020 -0600
> 
>         Fix vector-compare-1 regressions on sh4/sh4eb caused by pattern
> clobbering T reg without expressing that in its RTL.
>     
>                 PR rtl-optimization/90275
>                 * config/sh/sh.md (mov_neg_si_t): Clobber the T register in the
>                 pattern.
And sadly, the only thing this fixed was the regressions recently flagged by the
tester.  It didn't fix any of the pre-existing failures.  Sigh.

jeff
> 



More information about the Gcc-patches mailing list