[Patch][LTO] Set proper DECL_ALIGN in offload_handle_link_vars (PR94233)

Tobias Burnus tobias@codesourcery.com
Sat Mar 21 15:04:09 GMT 2020


On 3/21/20 8:03 AM, Richard Biener wrote:

>> OK for the trunk?
> It should be TYPE_ALIGN (type). OK with that change.

I am confused. The patch has:
+       SET_DECL_ALIGN (link_ptr_var, TYPE_ALIGN (ptr_type_node));
which looks correct and to uses already TYPE_ALIGN?!?

> Note this fails to honor target bits so it might be better to lay out the decl properly?

However, that's a good point. Let's do it properly by calling layout_decl
— indirectly, by calling build_decl.

OK?

Tobias

-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lto-fix-v2.diff
Type: text/x-patch
Size: 1377 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20200321/50a64766/attachment.bin>


More information about the Gcc-patches mailing list