[Patch,comitted] libgomp/testsuite: ignore blank-line output for function-not-offloaded.c

Tobias Burnus tobias@codesourcery.com
Thu Mar 19 11:47:54 GMT 2020


The libgomp.c-c++-common/function-not-offloaded.c is supposed
to fail on "target offload_device_nonshared_as";
producing "unresolved symbol foo" and tons of additional
(fatal) errors by collect, ld, lto1, mkoffload, lto-wrapper etc.

On NVidia, the existing "dg-excess-errors" works, but
with AMDGCN this is insufficient as one still gets a FAIL
"1 blank line(s) in output"

That's solved by adding "dg-allow-blank-lines-in-output 1".
(I think the argument – or at least its value – is ignored
but "1" is used everywhere.)

This error only appears for C++ as the reason seems to be that
there are two unresolved symbols: "foo" and "__gxx_personality_v0".
Those error messages are separated by an empty line.

Hence, this change could be undone as soon as cc1plus and a minimal
libstdc++ (libsupc++) is available for AMDGCN; however, for the
purpose of the test, the "dg-allow-blank-lines-in-output" can
remain even after __gxx_personality_v0 is available.(*)

Committed as r10-7275-gbb83e069ebadf0a724298f80a65b1775eff9cfab

Cheers,

Tobias
(*) The lack of __gxx_personality_v0 shows also up in the following
tests, i.e. that issue is already covered:
libgomp.c++/for-15.C
libgomp.c++/for-24.C
libgomp.oacc-c++/../libgomp.oacc-c-c++-common/routine-1.c
libgomp.oacc-c++/pr71959.C
libgomp.oacc-c++/routine-1-auto.C
libgomp.oacc-c++/routine-1-template-auto.C
libgomp.oacc-c++/routine-1-template-trailing-return-type.C
libgomp.oacc-c++/routine-1-template.C
libgomp.oacc-c++/routine-1-trailing-return-type.C

-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: committed.diff
Type: text/x-patch
Size: 1383 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20200319/4bb58cba/attachment.bin>


More information about the Gcc-patches mailing list