[PATCH 6/6] i386: Use ix86_output_ssemov for MMX TYPE_SSEMOV

H.J. Lu hjl.tools@gmail.com
Thu Mar 12 10:52:59 GMT 2020


On Wed, Mar 11, 2020 at 8:53 PM Jeff Law <law@redhat.com> wrote:
>
> On Sat, 2020-02-29 at 06:16 -0800, H.J. Lu wrote:
> > There is no need to set mode attribute to XImode since ix86_output_ssemov
> > can properly encode xmm16-xmm31 registers with and without AVX512VL.
> >
> > Remove ext_sse_reg_operand since it is no longer needed.
> >
> >       PR target/89229
> >       * config/i386/i386.c (ix86_output_ssemov): Handle MODE_V1DF and
> >       MODE_V2SF.
> >       * config/i386/mmx.md (MMXMODE:*mov<mode>_internal): Call
> >       ix86_output_ssemov for TYPE_SSEMOV.  Remove ext_sse_reg_operand
> >       check.
> >       * config/i386/predicates.md (ext_sse_reg_operand): Removed.
> This is OK.   I think once this is in, patch #2 becomes OK because this patch
> adds V2SF handling in ix86_output_ssemov.

I need to take out the ext_sse_reg_operand removal since it is still being
used.  I added MODE_DI to to ix86_output_ssemov.

> Similarly I think patch #4 is OK once this one goes in since it adds V1DF as
> well.
>
> So perhaps an integration plan would be to immediately install #6, followed 24hrs
> later by patch #4, then 24hrs after patch #2.
>
> Then we can work on patch #5 and patch #3 where I think we go with patch #5 plus
> the MODE_SI hunk from patch #3.  THen 24hrs after that the remaining bits of
> patch #3.

I am enclosing the updated 5 remaining patches.  I will check in the
first one and
check in the rest one patch every 24hrs.

> I think that covers the whole series.
>

Thanks.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-i386-Use-ix86_output_ssemov-for-MMX-TYPE_SSEMOV.patch
Type: text/x-patch
Size: 3294 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20200312/6edd0529/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-i386-Use-ix86_output_ssemov-for-DFmode-TYPE_SSEMOV.patch
Type: text/x-patch
Size: 5796 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20200312/6edd0529/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-i386-Use-ix86_output_ssemov-for-DImode-TYPE_SSEMOV.patch
Type: text/x-patch
Size: 4604 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20200312/6edd0529/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-i386-Use-ix86_output_ssemov-for-SFmode-TYPE_SSEMOV.patch
Type: text/x-patch
Size: 5173 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20200312/6edd0529/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-i386-Use-ix86_output_ssemov-for-SImode-TYPE_SSEMOV.patch
Type: text/x-patch
Size: 4983 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20200312/6edd0529/attachment-0009.bin>


More information about the Gcc-patches mailing list