[PATCH] libstdc++: Add a __nonnnull__ attribute to std::string's _CharT* constructor

Ville Voutilainen ville.voutilainen@gmail.com
Sun Jun 28 21:27:53 GMT 2020


On Mon, 29 Jun 2020 at 00:16, Jonathan Wakely <jwakely@redhat.com> wrote:
> >Hmm, let's use dg-additional-options here too, and axe the pointless
> >-std=gnu++11.
>
> I agree the -std=gnu++11 isn't needed, but thre doesn't seem to be any
> advantage to dg-additional-options here. The reason I suggested it for
> th other tests was that it can take a target selector, so it can be
> used to add options for some targets only (in the case of the variant
> tests, only if the dialect is c++17 or later).
>
> Here you want the -Wnonnull added unconditionally, with no target
> selector, so dg-options works fine.

Right, I somehow managed to think that dg-additional-options amends options
and dg-options overrides them. Here my intent is certainly the former.


More information about the Gcc-patches mailing list