[PATCH] rs6000: Add support for __builtin_cpu_is ("power10")

Segher Boessenkool segher@kernel.crashing.org
Thu Jun 25 23:54:26 GMT 2020


Hi!

On Thu, Jun 25, 2020 at 06:36:51PM -0500, Peter Bergner wrote:
> rs6000: Add support for __builtin_cpu_is ("power10")
> 
> Add support for __builtin_cpu_is ("power10").  Also add documentation for
> the recently added "arch_3_1" and "mma" __builtin_cpu_supports arguments.

> gcc/
> 	* config/rs6000/rs6000-call.c (cpu_is_info) <power10>: New.
> 	<mma>: Remove unneeded ','.

The comma helps making the diff less for future additions (and, makes
merging/refactoring easier, that way).  A trailing comma was not allowed
with older C standards (or just with some implementations?), but it
should be fine with C++11 as we require now.  Is there something I am
missing here?

> 	* gcc/doc/extend.texi (PowerPC Built-in Functions): Document power10,
> 	arch_3_1 and mma.
> 
> gcc/testsuite/
> 	* gcc.target/powerpc/cpu-builtin-1.c: Add tests for power10, arch_3_1
> 	and mma.

> @@ -17199,6 +17201,8 @@ CPU supports ISA 2.06 (eg, POWER7)
>  CPU supports ISA 2.07 (eg, POWER8)
>  @item arch_3_00
>  CPU supports ISA 3.0 (eg, POWER9)
> +@item arch_3_1
> +CPU supports ISA 3.1 (eg, POWER10)

Nothing new apparently, but it is spelled "e.g." :-/  Oh well.

Okay for trunk (maybe leave out the comma part).  Thanks!


Segher


More information about the Gcc-patches mailing list