[PATCH] rs6000: add option -mblock-ops-unaligned-vsx

Segher Boessenkool segher@kernel.crashing.org
Fri Jul 24 22:16:27 GMT 2020


Hi Aaron,

On Fri, Jul 24, 2020 at 05:05:25PM -0500, acsawdey@linux.ibm.com wrote:
> This option is mostly being added to provide -mno-block-ops-unaligned-vsx.
> The default is set the same as -mefficient-unaligned-vsx. This option will
> control the use of unaligned VSX loads/stores in the inline expansion
> of memcpy() and memmove(). The use case for this would be if you're
> compiling code that is doing a memcpy to memory mapped device memory
> that is cache-inhibited. On some powerpc processors this requires the
> unaligned vsx ops to be emulated by the kernel which is very slow.

>         * config/rs6000/rs6000.c (rs6000_option_override_internal):
> 	Set the default value for the option.

What option?  The changelog hasn't mentioned any yet, this is the first
line :-)  Just spell it out, or reorder the lines?

>         * config/rs6000/rs6000.opt: Add -mblock-ops-unaligned-vsx.
>         * doc/invoke.texi: Document -mblock-ops-unaligned-vsx.


> +  if (TARGET_BLOCK_OPS_UNALIGNED_VSX) printf("TARGET_BLOCK_OPS_UNALIGNED_VSX\n");

Stray debug code?

Okay for trunk with those details taken care of.  Thank you!


Segher


More information about the Gcc-patches mailing list