Fortran : Fortran translation issues PR52279

[Mark Eggleston]

On 02/07/2020 13:25, David Edelsohn wrote:
> On Thu, Jul 2, 2020 at 6:16 AM Mark Eggleston
> <mark.eggleston@codethink.co.uk> wrote:
>> I've committed the change from array to pointer. Does this fix your builds?
>>
>> On 02/07/2020 08:18, Mark Eggleston wrote:
>>> On 01/07/2020 20:07, David Edelsohn wrote:
>>>> This patch breaks bootstrap.
>>> Apologies. I didn't see this when I built the compiler the with
>>> bootstrap on x86_64. I'll endevour to get it fixed as soon as possible.
> Mark,
>
> Your change did nothing because I previously had removed the
> translation markers to restore bootstrap.  You were not sufficiently
> observant to check the ChangeLog or notice that the line already was
> changed.
>
> Please stop making random, untested changes.  This is inappropriate
> for GCC development.
OK. I had no way of confirming as the bootstrap worked for me. I naively 
thought that it was covered as an "obvious" fix.

I was concerned that I caused a breakage and wanted to fix it.

Regarding the ChangeLog I was unfamiliar with this situation and will 
check them if this ever happens again (I hope not).  I'll also keep 
portability issues in mind.

I see the issue of the incorrect hint text has been addressed. As I 
understand it the string as is will not make it to the pot file so will 
not be translated, is that acceptable? I would like to be able to close 
the PR.

regards,

Mark

> Thanks, David
>
-- 
https://www.codethink.co.uk/privacy.html