ipa: Fix removal of multi-target speculation
Martin Liška
mliska@suse.cz
Wed Jan 29 12:54:00 GMT 2020
On 1/29/20 1:39 PM, Jan Hubicka wrote:
>>> diff --git a/gcc/testsuite/gcc.dg/tree-prof/indir-call-prof-2.c b/gcc/testsuite/gcc.dg/tree-prof/indir-call-prof-2.c
>>> index 61612b5b628..bbba0521018 100644
>>> --- a/gcc/testsuite/gcc.dg/tree-prof/indir-call-prof-2.c
>>> +++ b/gcc/testsuite/gcc.dg/tree-prof/indir-call-prof-2.c
>>
>> This should be a new file.
> Sorry, git is still not my friend. I am used to add new files when I
> star them, then fix them and then expect them as new files in diff.
Then it's a diff against a file in git index. Then you need to do something like:
$ git diff HEAD
> git insists on diffing over the original file I added.
Anyway, I would definitely recommend to make a commit and then send
a result with git format-patch -1 HEAD. That's more safe than a diff.
Martin
>>
>>> @@ -1,25 +1,28 @@
>>> /* { dg-options "-O2 -fno-early-inlining -fdump-ipa-profile-optimized -fdump-ipa-afdo" } */
>>> volatile int one;
>>> -static
>>> -int add1 (int val)
>>> +static int
>>> +add1 (int val)
>>> {
>>> - return val+=one;
>>> + return val += one;
>>> }
>>> -static
>>> -int sub1 (int val)
>>> +
>>> +static int
>>> +sub1 (int val)
>>> {
>>> - return val-=one;
>>> + return val -= one;
>>> }
>>> -static
>>> -int do_op (int val, int (*fnptr) (int))
>>> +
>>> +static int
>>> +do_op (int val, int (*fnptr) (int))
>>> {
>>> return fnptr (val);
>>> }
>>> +
>>> int
>>> -main(void)
>>> +main (void)
>>> {
>>> - int i,val;
>>> - for (i=0;i<100000;i++)
>>> + int i, val = 0;
>>> + for (i = 0; i < 100000; i++)
>>> {
>>> val = do_op (val, add1);
>>> val = do_op (val, sub1);
>>> diff --git a/libgcc/libgcov-merge.c b/libgcc/libgcov-merge.c
>>
>> ... and this should not be installed.
>
> .. and this was accidentally included in patch (it is hack to disable
> reproducibility).
> Thanks for pointing this out.
>
> Honza
>
More information about the Gcc-patches
mailing list