[PATCH Coroutines]Access promise via actor function's frame pointer argument

Nathan Sidwell nathan@acm.org
Mon Jan 27 15:50:00 GMT 2020


On 1/21/20 5:19 AM, Iain Sandoe wrote:
> Hi Nathan, Bin,
> 
> bin.cheng <bin.cheng@linux.alibaba.com> wrote:

> 
> Nathan, is this OK for trunk as-is?
> thanks
> Iain


ok, with one nit I noticed:
> +act_des_fn (tree orig, tree fn_type, tree coro_frame_ptr, const char* name)

that final parameter should be 'const char *name' -- the '*' clings to 
the name not the type.


>> Patch updated as attached.
>>
>> Thanks,
>> bin
>>
>> gcc/cp
>> 2020-01-20  Bin Cheng  <bin.linux@linux.alibaba.com>
>>          * coroutines.cc (act_des_fn): New.
>>          (morph_fn_to_coro): Call act_des_fn to build actor/destroy decls.
>>          Access promise via actor function's frame pointer argument.
>>          (build_actor_fn, build_destroy_fn): Use frame pointer argument.
>>
>>
>>


-- 
Nathan Sidwell



More information about the Gcc-patches mailing list