*ping* Re: [patch, fortran] Fix PR 85781, ICE on valid

[Tobias Burnus]

Admittedly an early PING.

On 1/22/20 11:59 AM, Tobias Burnus wrote:
> Hi Thomas, hi all,
>
> first, I have now attached a different fix for PR 85781 (= original 
> bug). Can you have a look?
>
> I have the feeling (but didn't check) that your patch does not handle 
> the following variant of the test case: "print *, x(m:n)" (i.e. the 
> lower bound is not known at compile time).

I confirmed that my suspicion was right: the "resolve_substring" patch 
(first patch in this email thread) is not sufficient as all my test 
cases (of this patch) will still ICE with it.

> I hope my patch covers all issues. – OK for the trunk?

Cheers,

Tobias

> Secondly:
>
> On 1/21/20 7:32 PM, Thomas König wrote:
>>>> the attached patch fixes an ICE which could occur for empty
>>>> substrings (see test case).
>>> I think one should rather fix the following issue.
>> I am not sure what you mean.  Does that mean that fixing the following
>> issue will also fix PR 85781
>
> I am no longer sure what I meant myself ;-)
>
> I initially thought those are directly related – but they now look 
> related but independent bugs:
>
> PR 85781 is about getting a non-ARRAY_TYPE (tree dump: "character") 
> and using it as ARRAY_TYPE (tree dump: "character[lb:ub]").
>
> While PR93336 is about (1) using  an ARRAY_TYPE when one should not. – 
> And, additionally, about missing diagnostic related to (2) bind(c) and 
> kind=4, (3) passing zero-length strings to non-zero-length dummy args, 
> (4) diagnostic about truncating too long strings (esp. if of 
> non-default, non-c_char kind).
>
> Tobias
>