Fix for LTO compromised autoconf test in libiberty

Jeff Law law@redhat.com
Wed Jan 15 09:23:00 GMT 2020


On Tue, 2020-01-14 at 23:33 +0000, Joseph Myers wrote:
> My preference is still what I said in 
> <https://gcc.gnu.org/ml/gcc-patches/2019-11/msg02003.html>;: either 
> eliminate C alloca from libiberty, or don't build it with any compiler 
> defining __GNUC__.  I'd be surprised if there are host compilers that 
> build libiberty, have the relevant optimizations but don't support alloca.
So here's a patch that I think kills the alloca bits.

intl/ was the most interesting in that it has several #if ALLOCA
thingies.  But I reviewed all them and I'm pretty sure we'll do the
right thing (they define HAVE_ALLOCA anytime __GNUC__ is defined).

I've bootstrapped and regression tested without issue, of course.  But
that doesn't really exercise the worrisome cases. I wanted to try and
bootstrap on aix7.2, but the machine is the farm takes several seconds
for every file/directory operation.  Clearly not feasible.  So I then
wanted to try on aix7.1, but it doesn't look like we've got a usable
xlc++.  Then I tried to build on Solaris 11 in the farm.  But no Oracle
C++ compiler seems to be installed on that box.

So I'd really appreciated it if someone could do a bootstrap with
something other than GCC, preferably on AIX, but Solaris would be fine
too.

Anyway, here's the patch which removes all the alloca crud that I think
should disappear.





-------------- next part --------------
A non-text attachment was scrubbed...
Name: alloca.patch
Type: text/x-patch
Size: 49315 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20200115/88c48880/attachment.bin>


More information about the Gcc-patches mailing list