[PATCH] fortran: ICE using undeclared symbol in array constructor, PR93484

Tobias Burnus tobias@codesourcery.com
Mon Feb 24 15:01:00 GMT 2020


On 2/24/20 3:50 PM, Mark Eggleston wrote:
> I've had a quick look and there doesn't appear to be a test for using 
> a non-constant for kind arguments. I think a proper set of tests for 
> invalid kind arguments that covers declarations and intrinsic 
> arguments should be added that is separate from this patch.  Should 
> that be done while we're in stage 4 or should it wait for stage 1?

Test cases can always go in* – and usually having them earlier is better 
than later. Besides, they cannot get forgotten if done now – and you 
already have a stub. If we find bugs, we can still consider whether we 
want to have them fixed now (Stage 4) or later (GCC 11 Stage 1 + 
possibly backported).

Tobias

*Well, kind of. Some "dg-" syntax errors can break the testsuite – and 
the release manager do not like any commit when the branch is "frozen". 
(Directly before a release; approx. 1–3 days freeze; used to check that 
everything builds fine before actually tagging a release.)



More information about the Gcc-patches mailing list