[PATCH] analyzer: fix ICE on pointer arithmetic with incomplete types [PR 93774]

[David Malcolm]

On Tue, 2020-02-18 at 08:57 +0100, Thomas König wrote:
> Hi David
> 
> in principle, any valid test case (especially for an ICE) should
> count as obvious and simple, so no approval should be needed.
> 
> Having said that, I think I would prefer a copy of the original test
> case rather than an include statement. Although we usually do not
> change or remove test cases, sometimes it is done for one reason or
> anotjer, and in this case I would prefer that the derived test case
> does not change automatically.

Thanks - I wasn't sure which approach was preferable here.

> So, all four of your test cases are OK if you change those which use
> include to a plain test case, maybe with a comment pointing to the
> original one. 

I'll go ahead and rework those tests accordingly.

> In the future, you can just commit this kind of test case as simple
> and obvious; we would appreciate a note to fortran@ if you do so.

Thanks - will do.

Dave