[x86] recompute opt flags after opt level change
Alexandre Oliva
oliva@adacore.com
Thu Dec 17 02:00:13 GMT 2020
Hello, Martin,
On Dec 16, 2020, Martin Liška <mliska@suse.cz> wrote:
> On 10/1/19 10:58 AM, Alexandre Oliva wrote:
>> + if (opts->x_flag_asynchronous_unwind_tables == 2)
>> + opts->x_flag_unwind_tables
>> + = opts->x_flag_asynchronous_unwind_tables = 1;
> Anyway the code seems fishy, shouldn't it be:
> if (opts->x_flag_asynchronous_unwind_tables == 2)
> opts->x_flag_unwind_tables
> = opts->x_flag_asynchronous_unwind_tables == 1; <---- '==' instead of '='
No, IIRC the idea was to assign 1 to both fields.
I can't tell for sure because I don't think I wrote this myself, IIRC my
patch just moved it.
--
Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/
Free Software Activist GNU Toolchain Engineer
Vim, Vi, Voltei pro Emacs -- GNUlius Caesar
More information about the Gcc-patches
mailing list