[PATCH] testsuite: Fix various scan-assembler-symbol-section issues

[Rainer Orth]

Hi David,

> On Fri, Dec 4, 2020 at 5:35 AM Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>
>> On AIX 7.2, there are changes like
>>
>> -PASS: g++.dg/gomp/tls-5.C -std=c++2a scan-assembler-symbol-section
>> symbol ^_?ir$ (found ir) has section ^\\.tbss|\\[TL\\] (found
>> _tls5.tls_[TL],4)
>> +PASS: g++.dg/gomp/tls-5.C -std=c++2a scan-assembler-symbol-section
>> symbol ^_?ir$ (found ir) has section ^\\.tbss|\\[TL\\] (found
>> _tls5.tls_[TL])
>>
>> i.e. the ",4" after (?) the section name is now stripped.  I believe
>> this is benign: David?
>
> The ",4" is the symbol alignment.  It is not necessary for the purpose
> of the tests.

fine, thanks for the clarification.

> Thanks for looking further into this problem.  As I mentioned in my
> earlier reply to the patch itself, I believe that this new feature and
> infrastructure change should have been tested and fixed on
> non-Linux/ELF/x86 architectures, not left as an exercise for the
> maintainers of other targets.  A patch that introduces regressions in
> the testsuite should be fixed or reverted and should be the
> responsibility of the author -- whether the change is to the compiler
> or to the testsuite.

Yes and no: given the trouble I had myself trying an AIX bootstrap and
test and the effort it took guiding Iain through a Solaris 11.3
bootstrap on gcc211, I fear it's unreasonable to demand developers to do
all this testing themselves: if you have to address only one issue per
unfamiliar target while trying to, we'll loose contributors very
quickly.  I believe we should be able to get the setup of the various
cfarm hosts better in sync with the guidelines documented in the wiki to
avoid such trouble.

Ultimately, something like the trybot feature of the (now mostly
defunct) gdb buildbots could ease such pre-commit tests.

But I fully agree that the original patch should have seen way wider
cross-platform testing before being committed: asking target maintainers
for help usually works well enough: one just cannot expect them to spot
any patch that might require such testing themselves.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University