[PATCH] v3: doc/implement-c.texi: About same-as-scalar-type volatile aggregate accesses, PR94600

Jeff Law law@redhat.com
Fri Dec 4 18:54:45 GMT 2020



On 12/4/20 7:51 AM, Hans-Peter Nilsson via Gcc-patches wrote:
>> From: Martin Sebor via Gcc-patches <gcc-patches@gcc.gnu.org>
>> Date: Fri, 4 Dec 2020 01:49:51 +0100
>> On 12/3/20 12:14 PM, Hans-Peter Nilsson via Gcc-patches wrote:
>>> Belatedly, here's an updated version, using Martin Sebor's
>>> suggested wording from
>>> "https://gcc.gnu.org/pipermail/gcc-patches/2020-July/549580.html".
>>> I added two commas, hopefully helpfully.  Albeit ok'd by Richard
>>> Biener in
>>> "https://gcc.gnu.org/pipermail/gcc-patches/2020-July/549922.html",
>>> better have this reviewed properly, including markup (none added).
>>>
>>> Ok for trunk (gcc-11) and gcc-10?
>> Thanks for taking my suggestion!
> You're welcome!
>
>> These are just formatting nits but I would only further suggest
>> to enclose the name S (since it names a type) and the second
>> volatile in an @code{} directive (since it's a keyword).
>> (The volatile in volatile access is not one so it shouldn't
>> be formatted that way.)
> Here we go, and now with all the right email-addresses.
> Also, I inspected info and pdf output.  Yes, the last S ends up
> on a line by its own in the pdf.  I didn't think it was worth
> fixing by e.g. messing with the word order.
>
> BTW, "make -j 4 info pdf" from the top-level doesn't work;
> something is messed up in dependencies.  From a non-j "make info
> pdf" it looks like libgcc wanted to compile stuff (no "all-gcc"
> was done).
>
> ---
> We say very little about reads and writes to aggregate /
> compound objects, just scalar objects (i.e. assignments don't
> cause reads).  Let's lets say something safe about aggregate
> objects, but only for those that are the same size as a scalar
> type.
>
> There's an equal-sounding section (Volatiles) in extend.texi,
> but this seems a more appropriate place, as specifying the
> behavior of a standard qualifier.
>
> Ok for trunk (gcc-11) and gcc-10?
>
> gcc:
>
> 2020-12-04  Hans-Peter Nilsson  <hp@axis.com>
> 	    Martin Sebor  <msebor@redhat.com>
>
> 	PR middle-end/94600
> 	* doc/implement-c.texi (Qualifiers implementation): Add blurb
>  	about access to the whole of a volatile aggregate object, only for
>  	same-size as a scalar object.
OK
jeff



More information about the Gcc-patches mailing list