[PATCH] [X86_64]: Enable support for next generation AMD Zen3 CPU

[Uros Bizjak]

On Fri, Dec 4, 2020 at 6:50 PM Kumar, Venkataramanan
<Venkataramanan.Kumar@amd.com> wrote:
>
> [AMD Public Use]
>
> Hi Uros
>
> > -----Original Message-----
> > From: Uros Bizjak <ubizjak@gmail.com>
> > Sent: Friday, December 4, 2020 2:30 PM
> > To: Kumar, Venkataramanan <Venkataramanan.Kumar@amd.com>
> > Cc: gcc-patches@gcc.gnu.org; Jan Hubicka (hubicka@ucw.cz)
> > <hubicka@ucw.cz>
> > Subject: Re: [PATCH] [X86_64]: Enable support for next generation AMD
> > Zen3 CPU
> >
> > [CAUTION: External Email]
> >
> > On Thu, Dec 3, 2020 at 4:29 PM Kumar, Venkataramanan
> > <Venkataramanan.Kumar@amd.com> wrote:
> > >
> > > [AMD Public Use]
> > >
> > >
> > >
> > >
> > > Hi Maintainers,
> > >
> > >
> > >
> > > PFA, the patch that enables support for the next generation AMD Zen3
> > CPU via -march=znver3.
> > >
> > > This is a very basic enablement patch. As of now the cost, tuning and
> > scheduler changes are kept same as znver2.
> > >
> > > Further changes to the cost and tunings will be done later.
> > >
> > >
> > >
> > > Ok for trunk ?
> >
> > Please also add a new target to multiversioning and corresponding
> > testcases. As an example, how this is done nowadays, please see a
> > submission for a different target at [1].
> >
> > BTW: It looks that multiversioning testcases lack AMD targets. Can you
> > please add a testcase similar to testsuite/g++.target/i386/mv16.C and also
> > add AMD targets to testsuite/gcc.target/i386/funcspec-56.inc.
> > (this can be done in a follow-up patch).
> >
> > [1]
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgcc
> > .gnu.org%2Fpipermail%2Fgcc-patches%2F2020-
> > July%2F549699.html&data=04%7C01%7CVenkataramanan.Kumar%40
> > amd.com%7Cb53d6be6a0d6439396ae08d8983308e9%7C3dd8961fe4884e
> > 608e11a82d994e183d%7C0%7C0%7C637426692241855598%7CUnknown
> > %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> > WwiLCJXVCI6Mn0%3D%7C1000&sdata=VAPPvfzv%2FMCRiXSn2eBNn
> > 7bVIReoEHLkAtFgV%2BTFR4I%3D&reserved=0
> >
>
> Please find attached the version 2 patch.
>
> I have made additional changes as suggested by you.
> 1.  Added the AMD Zen targets to funcspec-56.inc file in the tests.
> 2.  To covers multiversioning  added a new test with some set of AMD targets detected by builtin_cpus similar to mv16.C.
>
> is ok for trunk ?

LGTM (I didn't review scheduling changes in detail).

Uros.