[PATCH] Remove misleading debug line entries

Richard Biener rguenther@suse.de
Wed Dec 2 07:50:42 GMT 2020


On Tue, 1 Dec 2020, Bernd Edlinger wrote:

> Hi!
> 
> 
> This removes gimple_debug stmts without block info after a
> NULL INLINE_ENTRY.
> 
> The line numbers from these stmts are from the inline function,
> but since the inline function is completely optimized away,
> there will be no DW_TAG_inlined_subroutine so the debugger has
> no callstack available at this point, and therefore those
> line table entries are not helpful to the user.
> 
> 2020-11-20  Bernd Edlinger  <bernd.edlinger@hotmail.de>
> 
> 	* cfgexpand.c (expand_gimple_basic_block): Remove debug_begin_stmts
> 	following a removed debug_inline_entry.
> 
> 
> Bootstrapped and reg-tested on x86_64-pc-linux-gnu.
> Is it OK for trunk?

So are those visited by clear_unused_block_pointer?  If so wouldn't
it be more appropriate to remove those there, when we elide the
inlined block scope?

Thanks,
Richard.

> 
> Thanks
> Bernd.
> 

-- 
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg,
Germany; GF: Felix Imendörffer; HRB 36809 (AG Nuernberg)


More information about the Gcc-patches mailing list