Import AMD HSA API headers

Jeff Law law@redhat.com
Wed Dec 2 05:25:36 GMT 2020



On 11/24/20 9:16 AM, Andrew Stubbs wrote:
> Hi David, All,
>
> As previously discussed, we need import some new headers for the
> ROC/HSA Runtime (for the amdgcn GPU port).
>
> These are the same files that can be found in the ROCr sources and
> install, but AMD have kindly relicensed them using Boost for use in
> GCC (the original license was Illinois, which has a troublesome
> attribution clause).
>
> The import has already been approved in principle by RMS, so I'm
> really just asking if I need to add/update any new README/COPYING, or
> move them to a different location, or something.
>
> OK to commit?
>
> Thanks
>
> Andrew
>
> P.S. I will follow up with a patch to actually use the new features in
> the near future.
>
> 201124-hsa-header.patch
>
> Import HSA header files from AMD
>
> These are the same header files that exist in the Radeon Open Compute Runtime
> project (as of October 2020), but they have been specially relicensed by AMD
> for use in GCC.
>
> The header files retain AMD copyright.
>
> include/ChangeLog:
>
> 	* hsa.h: Replace whole file.
> 	* hsa_ext_amd.h: New file.
> 	* hsa_ext_image.h: New file.
>
> libgomp/ChangeLog:
>
> 	* plugin/plugin-gcn.c: Include hsa_ext_amd.h.
> 	(HSA_AMD_AGENT_INFO_COMPUTE_UNIT_COUNT): Delete redundant definition.
OK.  I was concerned about AMD keeping the copyright and the fact that
the copyright is not [L]GPL.  But if RMS has OK'd it from that
standpoint, then I think we're for pushing into the trunk.

Jeff



More information about the Gcc-patches mailing list