[PATCH] rs6000, restrict bfloat convert intrinsic to Power 10. Fix BU_P10V macro definitions.

Segher Boessenkool segher@kernel.crashing.org
Thu Aug 27 18:34:25 GMT 2020


On Thu, Aug 27, 2020 at 08:43:40AM -0700, Carl Love wrote:
> 2020-08-26  Carl Love  <cel@us.ibm.com>
> 	* config/rs6000/rs6000-builtin.def: (BU_P10V_VSX_1) New builtin macro expansion.
> 	(XVCVBF16SPN, XVCVSPBF16): Replace macro expansion BU_VSX_1 with BU_P10V_VSX_1.
> 	* config/rs6000/rs6000-call.c: (VSX_BUILTIN_XVCVSPBF16, VSX_BUILTIN_XVCVBF16SPN):
> 	Replace with P10V_BUILTIN_XVCVSPBF16, P10V_BUILTIN_XVCVBF16SPN respectively.

(lines too long)

This patch is fine for GCC 10.  Thanks!

As an aside:

> -    case VSX_BUILTIN_XVCVSPBF16:
> -    case VSX_BUILTIN_XVCVBF16SPN:
> +    case P10V_BUILTIN_XVCVSPBF16:
> +    case P10V_BUILTIN_XVCVBF16SPN:

Having "P10V" in the name here doesn't really help anything; in fact, it
could just be BUILTIN_XVCBCVXBCXBNVC?  Simpler names like that will
improve readability as well.  But that is all for the future :-)


Segher


More information about the Gcc-patches mailing list