[Patch] Fortran: Add 'device_type' clause to OpenMP's declare target

Andre Vehreschild vehre@gmx.de
Thu Aug 20 16:10:47 GMT 2020


Hi Tobias,

to me this looks OK now.

Regards,
	Andre

On Thu, 20 Aug 2020 11:51:50 +0200
Tobias Burnus <tobias@codesourcery.com> wrote:

> Updated patch – taking Andre's suggestions into account +
> extending the testcase, which now catches the previous (NO)HOST
> module issue.
> 
> OK?
> 
> Tobias
> 
> On 8/19/20 2:51 PM, Tobias Burnus wrote:
> > Am 18.08.20 um 19:33 schrieb Andre Vehreschild:  
> >> +    case OMP_DEVICE_TYPE_HOST:
> >> +      MIO_NAME (ab_attribute) (AB_OMP_DEVICE_TYPE_NOHOST, attr_bits);
> >> Why also NOHOST here?  
> > Copy and paste error.  
> ...
> >> +      tree clauses = NULL_TREE;
> >> Would you mind using "omp_clauses" or the like here?  
> Done now.
> -----------------
> Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
> Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung,
> Alexander Walter


-- 
Andre Vehreschild * Email: vehre ad gmx dot de 


More information about the Gcc-patches mailing list