[Patch 1/5] rs6000, Add 128-bit sign extension support

Segher Boessenkool segher@kernel.crashing.org
Thu Aug 13 17:36:05 GMT 2020


Hi!

On Tue, Aug 11, 2020 at 12:22:37PM -0700, Carl Love wrote:
> +/* Sign extend builtins that work on ISA 3.0, but not defined until ISA 3.1.  */

What does this mean?  Not defined in GCC before now?  Does it need
backporting?  Not defined in older versions of the ELFv2 ABI (or vector
doc) and we do not want a backport?

> +  /* Sign extend builtins that work work on ISA 3.0, not added until ISA 3.1 */

Same (also "work work").

> +uThe following sign extension builtins are provided.

(stray "u")

> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/powerpc/p9-sign_extend-runnable.c
> @@ -0,0 +1,128 @@
> +/* { dg-do run { target { powerpc*-*-linux* && { lp64 && p9vector_hw } } } } */

/* { dg-do run { target { lp64 && p9vector_hw } } } */

or such; or do you require Linux actually?

> +/* { dg-options "-O2 -mdejagnu-cpu=power9 -save-temps" } */

Is -save-temps needed?  Not for the scan-assembler at least.

Okay for trunk with those details take care of.  Thanks!


Segher


More information about the Gcc-patches mailing list