[PATCH] rs6000: ICE when using an MMA type as a function param

Segher Boessenkool segher@kernel.crashing.org
Thu Aug 13 00:49:51 GMT 2020


On Wed, Aug 12, 2020 at 02:24:33PM -0500, Peter Bergner wrote:
> On 8/11/20 9:00 PM, Segher Boessenkool wrote:
> > On Sun, Aug 09, 2020 at 10:03:35PM -0500, Peter Bergner wrote:
> >> +/* { dg-options "-mdejagnu-cpu=power10 -O2 -w" } */
> > 
> > Do you need -w or could a less heavy hammer work as well?
> 
> So adding:
> 
> extern void bar0(); etc. was enough to get rid of the warnings, so
> I'll add that and remove the use of -w.

Great.

> >> It's a static local variable, so how is it always zero and unused?
> > 
> > Oh, trickiness with it being called a second time.  Ouch!
> > 
> > This needs a H U G E comment then...  Or better, get rid of that?
> 
> We cannot really get rid if it.

"Implement that some other way".  Expecting the compiler to only call
the param handling thing for the same function eight times in order,
never interleaved with something else, is asking for trouble.

But okay; just document the static :-)

> I'll modify the test case and add a comment here and then resend the patch.

Thanks!


Segher


More information about the Gcc-patches mailing list