[PATCH] testsuite: Add -fno-common to pr82374.c [PR94077]

Jakub Jelinek jakub@redhat.com
Wed Aug 12 09:08:15 GMT 2020


On Wed, Aug 12, 2020 at 05:03:45PM +0800, Kewen.Lin wrote:
> Hi,
> 
> As the PR comments show, the case gcc.dg/gomp/pr82374.c fails
> on Power7 since gcc8.  But it passes from gcc10.  By looking
> into the difference, it's due to that gcc10 sets -fno-common
> as default, which makes vectorizer force the alignment and
> be able to use aligned vector load/store on those targets which
> doesn't support unaligned vector load/store (here it's Power7).
> 
> As Jakub suggested in the PR, this patch is to append -fno-common
> into dg-options.
> 
> Verified with gcc8 release on ppc64-redhat-linux (Power7).
> 
> Is it ok for gcc8 and gcc9 release?
> 
> I guess for gcc10 and trunk, we can just let it alone?
> 
> BR,
> Kewen
> -----
> gcc/testsuite/ChangeLog:
> 
> 	PR testsuite/94077
> 	* gcc.dg/gomp/pr82374.c: Add option -fno-common.

Ok for 8/9, thanks.

	Jakub



More information about the Gcc-patches mailing list