std:vec for classes with constructor? (Was: Re: [patch] multi-range implementation for value_range (irange))

Martin Jambor mjambor@suse.cz
Wed Aug 5 15:09:19 GMT 2020


On Fri, Jul 31 2020, Aldy Hernandez via Gcc-patches wrote:
>

[...]

>
> * ipa-cp changes from vec<value_range> to std::vec<value_range>.
>
> We are using std::vec to ensure constructors are run, which they aren't 
> in our internal vec<> implementation.  Although we usually steer away 
> from using std::vec because of interactions with our GC system, 
> ipcp_param_lattices is only live within the pass and allocated with calloc.
>

Ummm... I did not object but I will save the URL of this message in the
archive so that I can waive it in front of anyone complaining why I
don't use our internal vec's in IPA data structures.

But it actually raises a broader question: was this supposed to be an
exception, allowed only not to complicate the irange patch further, or
will this be generally accepted thing to do when someone wants to have a
vector of constructed items?

Thanks,

Martin


More information about the Gcc-patches mailing list