[PATCH] Aarch64: Add missing clobber for fjcvtzs

Kyrylo Tkachov Kyrylo.Tkachov@arm.com
Tue Aug 4 08:30:33 GMT 2020


Hi Andrea,

> -----Original Message-----
> From: Andrea Corallo <Andrea.Corallo@arm.com>
> Sent: 04 August 2020 09:28
> To: gcc-patches@gcc.gnu.org
> Cc: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>; Richard Earnshaw
> <Richard.Earnshaw@arm.com>; Richard Sandiford
> <Richard.Sandiford@arm.com>
> Subject: Re: [PATCH] Aarch64: Add missing clobber for fjcvtzs
> 
> Hi all,
> 
> looking into the regression I realized I've got the condition into the
> effective target test wrong (== vs !=).  Apologies for the noise.
> 
> Bootstrapped on aarch64-none-linux-gnu and regresssioned on
> aarch64-none-elf.
> 
> Still okay for trunk and to backport on gcc-10?

I just remembered a recurring bit of review feedback from Ramana on my patches...
New effective target checks need to be documented in doc/sourcebuild.texi.

Ok with the documentation.
Thanks,
Kyrill

> 
> Thanks
> 
>   Andrea
> 
> gcc/ChangeLog
> 
> 2020-07-30  Andrea Corallo  <andrea.corallo@arm.com>
> 
> 	* config/aarch64/aarch64.md (aarch64_fjcvtzs): Add missing
> 	clobber.
> 
> gcc/testsuite/ChangeLog
> 
> 2020-07-30  Andrea Corallo  <andrea.corallo@arm.com>
> 
> 	* gcc.target/aarch64/acle/jcvt_2.c: New testcase.
> 	* lib/target-supports.exp
> 	(check_effective_target_aarch64_fjcvtzs_hw): Add new check for
> 	FJCVTZS hw.
> 


More information about the Gcc-patches mailing list