[PATCH] diagnostics: get_option_html_page fixes

[David Malcolm]

On Thu, 2020-04-30 at 15:02 +0200, Jakub Jelinek wrote:
> Hi!
> 
> (Sorry to David, apparently I've posted it only privately, not to
> gcc-patches, so reposting).
> 
> While testing the --with-documentation-root-url= changes, I run into
> [Wreturn-type] URL pointing to gfortran documentation where it
> obviously
> isn't documented.  The following patch updates the list of options to
> match
> reality (on the other side -Wconversion-extra is gfortran only option
> documented in gfortran.texi).
> 
> Or, perhaps better use the attached patch instead, which doesn't have
> a
> hardcoded list and instead uses the flags?  I went through options.c
> and the updated list of options matches exactly the cases where
> CL_Fortran
> is set for "-W*" options together with CL_C and/or CL_CXX (ok, there
> is also
> -Wall and -Wextra, but hopefully we don't emit [Wall] or [Wextra] for
> anything).
> 
> I have successfully bootstrapped/regtested the second patch (CL_C &
> CL_CXX)
> on x86_64-linux and i686-linux, ok for trunk, or do you prefer the
> first
> one?

Thanks for working on this; sorry for getting these wrong.

Is is possible to build gfortran without C and C++?  If so, then if I'm
reading things right the second patch (CL_C & CL_CXX) would get it
wrong for various Fortran warnings for such a build, as the CL_C/CL_CXX
wouldn't be defined and it will erroneously use the Fortran docs page,
rather than the common one for them.

The second patch seems so much cleaner that having a hardcoded list,
but getting the correct result is more important.

Dave