[Version 4][PATCH][gcc][PR94230]provide an option to change the size limitation for -Wmisleading-indent

Qing Zhao QING.ZHAO@ORACLE.COM
Mon Apr 27 14:23:21 GMT 2020


Hi, David,

> On Apr 24, 2020, at 5:36 PM, David Malcolm <dmalcolm@redhat.com> wrote:
> 
> On Fri, 2020-04-24 at 17:22 -0500, Qing Zhao wrote:
>> Hi, Dave,
>> 
>> Thanks a lot for the review and comments.
>> I just updated the patch with all your suggestions, bootstrapped it
>> and run regression test, no any issue.
>> 
>> The newest patch is attached with this email.
>> 
>> Richard/Jakub, please advise on whether I can commit this patch to
>> Gcc10?
>> 
>> Thanks a lot.
>> 
>> Qing
>> 
> 
> Thanks Qing.  One more wording nit (sorry!)
> 
>> +	  if (!flag_large_source_files)
>> +	    inform (loc,
>> +		    "adding %<-flarge-source-files%> will allow for more" 
>> +		    " column-tracking support, at the expense of compilation"
>> +		    " and memory");
>                    ^^^^^^^^^^^^^
> Please add "time" here i.e.
>                    " time and memory”);

Added it in my local directory. (And attached).

Thanks.

Qing
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PR94230.patch
Type: application/octet-stream
Size: 4714 bytes
Desc: not available
URL: <https://gcc.gnu.org/pipermail/gcc-patches/attachments/20200427/892b02fe/attachment.obj>
-------------- next part --------------



> 
> 
> Dave
> 



More information about the Gcc-patches mailing list