[PATCH] Rename Deprecated to IgnoreWarn in *.opt files.

Jakub Jelinek jakub@redhat.com
Mon Sep 9 14:16:00 GMT 2019


On Mon, Sep 09, 2019 at 09:08:43AM -0500, Segher Boessenkool wrote:
> On Mon, Sep 09, 2019 at 04:04:01PM +0200, Jakub Jelinek wrote:
> > On Mon, Sep 09, 2019 at 08:56:17AM -0500, Segher Boessenkool wrote:
> > > Hi Martin,
> > > 
> > > On Mon, Sep 09, 2019 at 03:04:20PM +0200, Martin Liška wrote:
> > > > I'm suggesting to rename Deprecated to IgnoreWarn
> > > 
> > > That is an even worse name IMO.
> > > 
> > > Just call it Removed or Deleted or something like that?  Something that
> > > says what it _is_, not something that is an amalgamate of how we should
> > > handle it.
> > 
> > Well, the current Deprecated is essentially Ignore Warn(switch %qs is no longer supported)
> > so the name was meant to say that it is like Ignore with a warning,
> > the option is ignored after warning about it.
> > Though, the documentation needs to be clear, it isn't the option that was
> > removed, just the feature behind the option.
> 
> "IgnoreWarn" reads as "ignore the warning".
> 
> If we want it named as two things, can we just make it two things?
> "Ignore WarnDeleted" or something.  Which also says what it is warning
> about.

Or WarnRemoved.  Both work for me, but ultimately it would be best if Joseph
decides.

	Jakub



More information about the Gcc-patches mailing list