[Darwin, testsuite, committed] Fix Wnonnull on Darwin.

[Iain Sandoe]

Iain Sandoe <iain@sandoe.co.uk> wrote:

> Iain Sandoe <iain@sandoe.co.uk> wrote:
> 
>> Iain Sandoe <iain@sandoe.co.uk> wrote:
>> 
>>> Martin Sebor <msebor@gmail.com> wrote:
>>> 
>>>> On 10/20/2019 07:27 AM, Iain Sandoe wrote:
>>>>> Martin Sebor <msebor@gmail.com> wrote:
>>>>>> On 10/19/19 2:56 AM, Iain Sandoe wrote:
>>>>>>> Andreas Schwab <schwab@linux-m68k.org> wrote:
>>>>>>>> On Okt 19 2019, Iain Sandoe <iain@sandoe.co.uk> wrote:
>>>>>>>> 
>>>>>>>>> This test has failed always on Darwin, because Darwin does not mark
>>>>>>>>> entries in string.h with nonnull attributes.  Since the purpose of the test
>>>>>>>>> is to check that the warnings are issued for an inlined function, not that
>>>>>>>>> the target headers are marked up, we can provide locally marked up
>>>>>>>>> function declarations for Darwin.
>>>>>>>> 
>>>>>>>> If the test depends on the non-std declarations, then it should use them
>>>>>>>> everywhere.
>>>>>>> from my perspective, agreed, Martin?
>>>>>> 
>>>>>> I don't see a problem with it.  I prefer tests that don't depend
>>>>>> on system headers to avoid these kinds of issues
>>>>> We can do that anyway then, - I can just adjust the current code tor remove the
>>>>> special-casing, and to use __SIZE_TYPE__ instead of size_t everywhere, OK?
>>>> 
>>>> Sure.
>>> 
>>> Will try to get to it later today.
>> 
>> This is what I committed (will sort out backports, in due course).
> 
> backported to gcc-9 as r277647 (still needed on gcc-8).

backported to gcc-8 as r277696.

I think that’s all that’s needed here, 
Iain