Re: [Patch][Fortran] OpenMP – libgomp/testsuite – use 'stop' and 'dg-do run'

Tobias Burnus Tobias_Burnus@mentor.com
Wed Oct 30 10:57:00 GMT 2019


Hi,

thanks for the review.

On 10/30/19 10:31 AM, Jakub Jelinek wrote:
>> +++ b/libgomp/testsuite/libgomp.fortran/omp_orphan.f
>> +++ b/libgomp/testsuite/libgomp.fortran/omp_reduction.f
>> +++ b/libgomp/testsuite/libgomp.fortran/omp_workshare1.f
>> --- a/libgomp/testsuite/libgomp.fortran/omp_workshare2.f
>> +++ b/libgomp/testsuite/libgomp.fortran/omp_workshare2.f
> Dunno, maybe, though not clear advantages of doing so.

I didn't added 'dg-do run' for those.
Otherwise as suggested – and committed as Rev. 277606.

> I'm not really happy about the uppercase STOP in all the 
> libgomp.fortran tests that are written completely in lowercase except 
> these stops, but didn't get around to changing it yet.

How about the following patch? Created by
sed -i -e 's/STOP /stop /' in testsuite/libgomp.fortran/
and glanced over. (Seemingly, no all-capital-letters file exists.)

?

Tobias

-------------- next part --------------
A non-text attachment was scrubbed...
Name: STOP-stop.diff
Type: text/x-patch
Size: 199735 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20191030/7cf00c58/attachment.bin>


More information about the Gcc-patches mailing list