[PATCH] Add missing space in various string literals
Jakub Jelinek
jakub@redhat.com
Thu Oct 24 18:02:00 GMT 2019
Hi!
On Thu, Oct 24, 2019 at 01:20:26PM -0400, Marek Polacek wrote:
> Since r269045 we're missing a space in a diagnostic.
>
> Bootstrapped/regtested on x86_64-linux, applying to trunk and 9.
>
> 2019-10-24 Marek Polacek <polacek@redhat.com>
>
> * decl.c (reshape_init_r): Add missing space.
This change reminded me that it is time to run my
https://gcc.gnu.org/ml/gcc-patches/2017-02/msg00844.html
script again. While it has lots of false positives, it discovered quite a
few issues besides the bug you've fixed.
I'll commit this as obvious to trunk if it passes bootstrap/regtest.
2019-10-24 Jakub Jelinek <jakub@redhat.com>
* config/arc/arc.c (hwloop_optimize): Add missing space in string
literal.
* config/rx/rx.c (rx_print_operand): Likewise.
* tree-vect-data-refs.c (vect_analyze_data_refs): Likewise.
* tree-ssa-loop-ch.c (should_duplicate_loop_header_p): Likewise.
* ipa-sra.c (create_parameter_descriptors, process_scan_results):
Likewise.
* genemit.c (emit_c_code): Likewise.
* plugin.c (try_init_one_plugin): Likewise. Formatting fix.
cp/
* call.c (convert_arg_to_ellipsis): Add missing space in string
literal.
--- gcc/config/arc/arc.c.jj 2019-09-11 10:27:44.612703959 +0200
+++ gcc/config/arc/arc.c 2019-10-24 19:38:21.796846873 +0200
@@ -8001,7 +8001,7 @@ hwloop_optimize (hwloop_info loop)
return false;
}
if (dump_file)
- fprintf (dump_file, ";; loop %d has a control like last insn;"
+ fprintf (dump_file, ";; loop %d has a control like last insn; "
"add a nop\n",
loop->loop_no);
@@ -8011,7 +8011,7 @@ hwloop_optimize (hwloop_info loop)
if (LABEL_P (last_insn))
{
if (dump_file)
- fprintf (dump_file, ";; loop %d has a label as last insn;"
+ fprintf (dump_file, ";; loop %d has a label as last insn; "
"add a nop\n",
loop->loop_no);
last_insn = emit_insn_after (gen_nopv (), last_insn);
@@ -8038,7 +8038,7 @@ hwloop_optimize (hwloop_info loop)
if (entry_edge == NULL)
{
if (dump_file)
- fprintf (dump_file, ";; loop %d has no fallthru edge jumping"
+ fprintf (dump_file, ";; loop %d has no fallthru edge jumping "
"into the loop\n",
loop->loop_no);
return false;
--- gcc/config/rx/rx.c.jj 2019-09-11 10:27:41.266755350 +0200
+++ gcc/config/rx/rx.c 2019-10-24 19:39:53.224447237 +0200
@@ -649,7 +649,7 @@ rx_print_operand (FILE * file, rtx op, i
case CTRLREG_INTB: fprintf (file, "intb"); break;
default:
warning (0, "unrecognized control register number: %d"
- "- using %<psw%>", (int) INTVAL (op));
+ " - using %<psw%>", (int) INTVAL (op));
fprintf (file, "psw");
break;
}
--- gcc/cp/call.c.jj 2019-10-24 14:46:34.976751156 +0200
+++ gcc/cp/call.c 2019-10-24 19:43:52.416785521 +0200
@@ -7590,7 +7590,7 @@ convert_arg_to_ellipsis (tree arg, tsubs
&& TYPE_MODE (TREE_TYPE (prom)) != TYPE_MODE (arg_type)
&& (complain & tf_warning))
warning_at (loc, OPT_Wabi, "scoped enum %qT passed through %<...%>"
- "as %qT before %<-fabi-version=6%>, %qT after",
+ " as %qT before %<-fabi-version=6%>, %qT after",
arg_type,
TREE_TYPE (prom), ENUM_UNDERLYING_TYPE (arg_type));
if (!abi_version_at_least (6))
--- gcc/plugin.c.jj 2019-05-20 11:39:35.305796134 +0200
+++ gcc/plugin.c 2019-10-24 19:46:59.839916339 +0200
@@ -712,10 +712,10 @@ try_init_one_plugin (struct plugin_name_
if (dlsym (dl_handle, str_license) == NULL)
fatal_error (input_location,
"plugin %s is not licensed under a GPL-compatible license"
- "%s", plugin->full_name, dlerror ());
+ " %s", plugin->full_name, dlerror ());
- PTR_UNION_AS_VOID_PTR (plugin_init_union) =
- dlsym (dl_handle, str_plugin_init_func_name);
+ PTR_UNION_AS_VOID_PTR (plugin_init_union)
+ = dlsym (dl_handle, str_plugin_init_func_name);
plugin_init = PTR_UNION_AS_CAST_PTR (plugin_init_union);
if ((err = dlerror ()) != NULL)
--- gcc/tree-vect-data-refs.c.jj 2019-10-21 13:06:29.220299826 +0200
+++ gcc/tree-vect-data-refs.c 2019-10-24 19:51:53.689419065 +0200
@@ -4282,7 +4282,7 @@ vect_analyze_data_refs (vec_info *vinfo,
{
if (nested_in_vect_loop_p (loop, stmt_info))
return opt_result::failure_at (stmt_info->stmt,
- "not vectorized:"
+ "not vectorized: "
"not suitable for strided load %G",
stmt_info->stmt);
STMT_VINFO_STRIDED_P (stmt_info) = true;
--- gcc/tree-ssa-loop-ch.c.jj 2019-07-10 15:52:27.851038998 +0200
+++ gcc/tree-ssa-loop-ch.c 2019-10-24 19:45:17.011490491 +0200
@@ -199,7 +199,7 @@ should_duplicate_loop_header_p (basic_bl
if (dump_file && (dump_flags & TDF_DETAILS))
fprintf (dump_file,
" Not duplicating bb %i: condition based on non-IV loop"
- "variant.\n", header->index);
+ " variant.\n", header->index);
return false;
}
--- gcc/ipa-sra.c.jj 2019-09-26 21:34:26.847839161 +0200
+++ gcc/ipa-sra.c 2019-10-24 19:37:15.586860452 +0200
@@ -1137,8 +1137,8 @@ create_parameter_descriptors (cgraph_nod
&& TYPE_NONALIASED_COMPONENT (type))
{
if (dump_file && (dump_flags & TDF_DETAILS))
- fprintf (dump_file, " not a candidate, reference to a"
- "nonaliased component array\n");
+ fprintf (dump_file, " not a candidate, reference to "
+ "a nonaliased component array\n");
continue;
}
if (!is_gimple_reg (parm))
@@ -2284,8 +2284,8 @@ process_scan_results (cgraph_node *node,
if (nonarg_acc_size > param_size_limit
|| (!desc->by_ref && nonarg_acc_size == param_size_limit))
{
- disqualify_split_candidate (desc, "Would result into a too big set of"
- "replacements.");
+ disqualify_split_candidate (desc, "Would result into a too big set "
+ "of replacements.");
}
else
{
--- gcc/genemit.c.jj 2019-10-01 18:16:10.744161652 +0200
+++ gcc/genemit.c 2019-10-24 19:42:55.775652621 +0200
@@ -305,7 +305,7 @@ emit_c_code (const char *code, bool can_
else
printf ("#define FAIL _Pragma (\"GCC error \\\"%s cannot FAIL\\\"\")"
" (void)0\n", name);
- printf ("#define DONE return (_val = get_insns (),"
+ printf ("#define DONE return (_val = get_insns (), "
"end_sequence (), _val)\n");
rtx_reader_ptr->print_md_ptr_loc (code);
Jakub
More information about the Gcc-patches
mailing list