[PATCH, OBVIOUS] Fix -Wshadow=local warnings in gcc/[a-c]*.c

Segher Boessenkool segher@kernel.crashing.org
Mon Oct 7 07:36:00 GMT 2019


On Mon, Oct 07, 2019 at 08:56:44AM +0200, Richard Biener wrote:
> But I agree that mechanically "fixing" the current code-base, while ending up
> with no new introductions of local shadowing, is worse if it makes the current
> code-base worse.

Obfucating the names is not often a good fix for the "this code is too big
and complex" problem :-(

Good fixes for this cannot be done mechanically.

> This probably means fixing the header file issues first though.

Yeah, and those are some of the nastier issues anyway.  We need to try to
get rid of some more big macros.  Not the most exciting work, but useful.


Segher



More information about the Gcc-patches mailing list