[PATCH] Disable tests that aren't valid in parallel mode

Jonathan Wakely jwakely@redhat.com
Wed Oct 2 14:57:00 GMT 2019


On 01/10/19 21:59 +0100, Jonathan Wakely wrote:
>Tested x86_64-linux (normal and parallel modes), committed to trunk.

>commit b11c8f480fe1cd5696ec1a8f0db481c5f45429b8
>Author: Jonathan Wakely <jwakely@redhat.com>
>Date:   Tue Oct 1 20:31:51 2019 +0100
>
>    Disable tests that aren't valid in parallel mode
>    
>    Tests that depend on debug mode can't be tested in parallel mode.
>    
>            * testsuite/17_intro/using_namespace_std_tr1_neg.cc: Skip test for
>            parallel mode.
>            * testsuite/20_util/hash/84998.cc: Likewise.
>            * testsuite/23_containers/deque/types/pmr_typedefs_debug.cc: Likewise.
>            * testsuite/23_containers/forward_list/pmr_typedefs_debug.cc: Likewise.
>            * testsuite/23_containers/list/pmr_typedefs_debug.cc: Likewise.
>            * testsuite/23_containers/map/pmr_typedefs_debug.cc: Likewise.
>            * testsuite/23_containers/multimap/pmr_typedefs_debug.cc: Likewise.
>            * testsuite/23_containers/multiset/pmr_typedefs_debug.cc: Likewise.
>            * testsuite/23_containers/set/pmr_typedefs_debug.cc: Likewise.
>            * testsuite/23_containers/unordered_map/pmr_typedefs_debug.cc:
>            Likewise.
>            * testsuite/23_containers/unordered_multimap/pmr_typedefs_debug.cc:
>            Likewise.
>            * testsuite/23_containers/unordered_multiset/pmr_typedefs_debug.cc:
>            Likewise.
>            * testsuite/23_containers/unordered_set/pmr_typedefs_debug.cc:
>            Likewise.
>            * testsuite/23_containers/vector/cons/destructible_debug_neg.cc:
>            Likewise.
>            * testsuite/23_containers/vector/types/pmr_typedefs_debug.cc: Likewise.
>            * testsuite/25_algorithms/binary_search/partitioned.cc: Likewise.
>            * testsuite/25_algorithms/copy/86658.cc: Likewise.
>            * testsuite/25_algorithms/equal_range/partitioned.cc: Likewise.
>            * testsuite/25_algorithms/lexicographical_compare/71545.cc: Likewise.
>            * testsuite/25_algorithms/lower_bound/partitioned.cc: Likewise.
>            * testsuite/25_algorithms/upper_bound/partitioned.cc: Likewise.

The remaining failures for 'make check-parallel' are all in tests for C++20
constexpr and move-only function objects.

We should just document that Parallel Mode only really meets the C++03
requirements. For C++17 there are new parallel algorithms, and once
those are able to use OpenMP we should consider deprecating Parallel
Mode entirely.

This documents the limitation. Committed to trunk.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.txt
Type: text/x-patch
Size: 1882 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20191002/b1181e66/attachment.bin>


More information about the Gcc-patches mailing list