[PATCH] IPA-CP release transformation summary (PR jit/91928)

Andrea Corallo Andrea.Corallo@arm.com
Tue Oct 1 10:11:00 GMT 2019


Martin Jambor writes:

> Hi,
>
> On Mon, Sep 30 2019, Andrea Corallo wrote:
>> Hi all,
>> I'd like to submit this patch.
>> It release the ipa cp transformation summary after functions being expanded.
>> This is to fix the compiler when used with libgccjit on subsequent
>> compilations (every new compilation should have a clean transformation
>> summary).
>
> if this is a general problem then I think we should instead add another
> hook to class ipa_opt_pass_d to free transformation summary, call it for
> all IPA passes at the appropriate time and implement it for IPA-CP. That
> way it will work for all IPA passes which might have a transformation
> summary.
>
> Martin
>
>
>>
>> Bootstrap on arm64 and X86-64.
>>
>> Bests
>>   Andrea
>>
>> gcc/ChangeLog
>> 2019-??-??  Andrea Corallo  <andrea.corallo@arm.com>
>>
>> 	* cgraphunit.c (expand_all_functions): Release ipcp_transformation_sum
>> 	when finished.
>> 	* ipa-prop.c (ipcp_free_transformation_sum): New function.
>> 	* ipa-prop.h (ipcp_free_transformation_sum): Add declaration.

Hi,
actually looking around in order to implement the suggestions I realized
that already some code was put in place in toplev::finalize calling
then ipa_cp_c_finalize exactly for this purpose.

I've updated the patch accordingly.

Bootstraped on aarch64.

Is it okay for trunk?

Bests
  Andrea

gcc/ChangeLog
2019-??-??  Andrea Corallo  <andrea.corallo@arm.com>

	* ipa-cp.c (ipa_cp_c_finalize): Release ipcp_transformation_sum.
	* ipa-prop.c (ipcp_free_transformation_sum): New function.
	* ipa-prop.h (ipcp_free_transformation_sum): Add declaration.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 91928.patch
Type: text/x-diff
Size: 1407 bytes
Desc: 91928.patch
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20191001/38bdb20f/attachment.bin>


More information about the Gcc-patches mailing list